Skip to content

Set default hermes variable to SH stable, remove legacy hermes#54522

Closed
lavenzg wants to merge 1 commit into
react:mainfrom
lavenzg:export-D86885030
Closed

Set default hermes variable to SH stable, remove legacy hermes#54522
lavenzg wants to merge 1 commit into
react:mainfrom
lavenzg:export-D86885030

Conversation

@lavenzg

@lavenzg lavenzg commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

Summary:
As we are moving to SH stable as default, DEFAULT_HERMES_VARIANT should be set to SH stable.

Changelog: [Internal]

Differential Revision: D86885030

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2025
@meta-codesync

meta-codesync Bot commented Nov 12, 2025

Copy link
Copy Markdown

@lavenzg has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86885030.

@lavenzg @facebook-github-bot
Set default hermes variable to SH stable, remove legacy hermes (react…
9379eb3 
…#54522)

Summary:

As we are moving to SH stable as default, `DEFAULT_HERMES_VARIANT`
should be set to SH stable. Note that this will cause fantom tests
to be skipped in OSS for now.

Changelog: [Internal]

Reviewed By: tmikov

Differential Revision: D86885030
@yashhhh04

yashhhh04 commented Nov 16, 2025

Copy link
Copy Markdown

🤖 Automated Code Review

📊 Pull Request Review Summary

Overview

The pull request aims to set the default Hermes variant to static Hermes stable while removing references to legacy Hermes integration. This reflects a shift in the codebase towards improved and more stable configurations for the Hermes JS engine used in React Native.

🎯 Key Findings

  • Total Issues Found: 0
  • Critical: 0
  • High: 0
  • Medium: 0
  • Low: 0

🔍 Detailed Issues

🔴 Critical Issues

No critical issues found.

🟠 High Priority Issues

No high priority issues found.

🟡 Medium Priority Issues

No medium priority issues found.

🟢 Low Priority Issues

No low priority issues found.

✅ Positive Aspects

  • The removal of legacy Hermes references is a good step towards codebase cleanliness and maintainability.
  • The channeled focus towards using static Hermes stable should improve performance and reduce inconsistencies.
  • The updated memory limits in MemoryBaseline-itest.js indicate a proactive approach to handling development and optimization scenarios.

📝 Overall Assessment

This pull request does not introduce any issues and appropriately aligns the code with the latest standards for using Hermes within React Native. The code changes reflect a well-considered update that enhances performance and maintainability. It is recommended to merge this pull request as it sustains high code quality and adheres to project best practices.

✅ No issues found! Code looks good.

Generated by PR Review Agent

@react-native-bot

react-native-bot commented May 15, 2026

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label May 15, 2026
@react-native-bot

react-native-bot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Closing this PR as the diff D86885030 has been abandoned internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported p: Facebook Partner: Facebook Partner Stale There has been a lack of activity on this issue and it may be closed soon.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lavenzg @yashhhh04 @react-native-bot @facebook-github-bot